On Sat, 2017-03-04 at 11:29 +0300, Sergey Shambir wrote:
> +#if defined(_MSC_VER) // workaround slow ftello/fseeko prior to Visual
> Studio 2015
Hi,
thanks for the patches. I've only one nitpick about ftello/fseeko, as
discussed here on this list recently. The ftello/fseeko is actually not
used at all. It's changed to ftell/fseek on all but Win64 builds, where
_ftelli64/_fseeki64 is used instead; see PdfCompilerCompatPrivate.h.
My nitpick is more about your comment, you claim "before VS2015", but
you do not check for that version. Why? Can be due to consistency,
though then the comment is misleading a bit.
Bye,
zyx
--
http://www.litePDF.cz i...@litepdf.cz
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
