Hello zyx, hello all, > zyx has written on 22 October 2017 at 15:34: > > On 21.10.2017 0:59, Matthew Brincke wrote: > > attached is a patch against trunk r1860 (diff -up in svn format) for > > fixing the ABI (changing it back to the 0.9.5 state for the method > > PdfPage::GetInheritedKeyFromObject() after the fix for CVE-2017-5852). > > Hi, > thanks for the patch. I'm sorry, but I want to ask: what is the idea > behind this change, please? I agree that breaking API/ABI is not ideal, > but in case of the PoDoFo project the soname versions are bumped each > release, thus the idea of providing two methods instead of one with an > overloaded argument value doesn't add much to the library users.
you're welcome, the idea behind the change is to augment the fix for CVE-2017-5852 in svn r1838 [1] to make it a real security update, in which changing the ABI is not done (for distributors to cherry-pick, inspired by Debian bug 854600 [2], I wonder why no one answered to the last post ...) and to provide a little contribution to ABI stability in the future (sadly, PODOFO_LOCAL is not, AFAIUI in my research [3][4]: cannot be directly, supported on Windows). I mean, with this change committed, the stability of name-lookup-based ABI would be restored for the PoDoFo parts unaffected by the incremental-signing changes (now general incremental-update :-)) IIRC. I wonder why changing a private method is relevant to ABI at all, and (at least when you're still unconvinced ;-) to accept) would welcome your elucidation (if you have come across any, to date), please ... > Thanks and bye, > zyx Best regards, mabri [1] https://sourceforge.net/p/podofo/code/1838/ [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854600 [3] https://msdn.microsoft.com/en-us/library/81h27t8c.aspx [4] https://stackoverflow.com/questions/2810118/how-to-tell-the-mingw-linker-not-to-export-all-symbols ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
