On Thu, 2018-01-04 at 00:59 +0100, Matthew Brincke wrote:
> > the internal function name PODOFO_Base14FontDef_FindBuiltinData
> > looks like it should be in a namespace and a class IMHO, therefore
> > I've converted it to a private method with access only from
> > PdfFontFactory.
Hi,
I'm sorry, but what is the idea behind the change, please? If only the
above, then, well, from my point of view, it doesn't make much sense. I
see that it makes many things more complicated, defines classes inside
classes (while possible, I do not like it myself), requirement of
'friend' classes, which also kind of points into a bad/suboptimal API
design, and also:
> > Should someone desire access to any of this info outside PoDoFo,
> > some workaround is possible: e.g. create the font, query its
> > metrics and check if they can be converted (dynamic_cast) to
> > PdfFontMetricsBase14.
which is quite discouraging for me.
Just my opinion. If the maintainer will wish to commit the change, then
I'm not against it, I'm just not in favor of it myself.
Bye,
zyx
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
