On Wed, 2018-01-17 at 00:48 +0100, Matthew Brincke wrote:
> in that revision in src/doc/PdfPage.cpp:380 (i.e. line 380) there is
> a typo: it should be pItem instead of pObj (as in line 384 the index
> pItem is used for storing, so it should be used for querying also).
Hi,
thanks for the review, that is a really silly typo. I'm sorry about
that.
> An issue is also that you replaced the construct (*iterator).member
> by iterator->member which is AFAIK non-standard, so (possibly at
> least) non-portable.
Well, I've been told more than 20 years ago that one can use either
"(*a)." or "a->", because they are equivalent notations, which [2]
confirms for built-in types. I understand it that even if the overload
operator (the "overload" word is an important bit of the information)
is not defined, then it will still produce the same result. It's more
complicated when the iterator references a pointer, not a structure,
but that's far from this thread/paragraph. Nonetheless, I do not care
that much, it's just my habit, thus I changed that to "(*a)." notation.
Both done in revision 1868:
http://sourceforge.net/p/podofo/code/1868
Thanks again and bye,
zyx
[2]
http://en.cppreference.com/w/cpp/language/operator_member_access#Built-in_member_access_operators
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
