On Sat, Feb 10, 2018 at 10:47:41PM +0100, Matthew Brincke wrote:
> The CMake variable to set to express visibility support is now the unset
> PODOFO_HAVE_GCC_SYMBOL_VISIBILITY ("GCC" means "GCC-compatible" here).
> This variable should be set by a feature test in the CMakeLists.txt which
> I'm sorry for not being able to implement right now, I've never done such
> and would really like to contribute other fixes too (@Dom: until which time?).I asked around this a bit some weeks ago, and it seems that a way to do it is to use CHECK_C_COMPILER_FLAG / CHECK_CXX_COMPILER_FLAG (which comes from /usr/share/cmake-3.9/Modules/CheckCXXCompilerFlag.cmake and is even available for cmake back 2.6, so there should be no need to vendor that .cmake file). That doesn't cover a case that for example libssh's variant does: https://sources.debian.org/src/libssh/0.8.0~20170825.94fa1e38-1/ConfigureChecks.cmake/?hl=40#L37 There it tries to build 'void __attribute__((visibility(\"default\"))) test() {} int main(void){ return 0; }' with -fvisibility=hidden. Apparently, according to one person from my IRC circle, ISTR -fvisibility=hidden is quietly accepted by any new enough GCC, but when you actually try to use the attribute you get warnings if the target platform doesn't support it. so to avoid a very noisy build on such platforms you may want to run a test compile with -Werror I'll leave to whoever implements this to figure out the best course of action. > > bunch of exported symbols, alas not that many, probably more > > PODOFO_LOCAL and PODOFO_API are still needed through the codebase. > > Yes, probably, I hope that can still be changed after the release candidate. I don't think there is any need to rush this part, or get crazy about. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
