Hi John,
Thanks for your patch. When initially applied, your patch is causing this
compilation error for me:
/home/dominik/Desktop/Programming/podofo/podofo/src/base/PdfFiltersPrivate.cpp:
In member function ‘void PoDoFo::PdfPredictorDecoder::Decode(const char*,
PoDoFo::pdf_long, PoDoFo
::PdfOutputStream*)’:
/home/dominik/Desktop/Programming/podofo/podofo/src/base/PdfFiltersPrivate.cpp:197:58:
error:
expected primary-expression before ‘unsigned’
int a = nLeftByteIndex < 0 ? 0 : unsigned char(
m_pPrev[nLeftByteIndex] );
^~~~~~~~
/home/dominik/Desktop/Programming/podofo/podofo/src/base/PdfFiltersPrivate.cpp:198:33:
error:
expected primary-expression before ‘unsigned’
int b = unsigned char( m_pPrev[m_nCurRowIndex] );
^~~~~~~~
/home/dominik/Desktop/Programming/podofo/podofo/src/base/PdfFiltersPrivate.cpp:201:58:
error:
expected primary-expression before ‘unsigned’
int c = nLeftByteIndex < 0 ? 0 : unsigned char(
m_pUpperLeftPixelComponents[nCurrComponentIndex] );
^~~~~~~~
src/CMakeFiles/podofo_shared.dir/build.make:398: die Regel für Ziel
„src/CMakeFiles/podofo_shared.dir/base/PdfFiltersPrivate.cpp.o“ scheiterte
make[2]: ***
[src/CMakeFiles/podofo_shared.dir/base/PdfFiltersPrivate.cpp.o] Fehler 1
CMakeFiles/Makefile2:117: die Regel für Ziel
„src/CMakeFiles/podofo_shared.dir/all“ scheiterte
make[1]: *** [src/CMakeFiles/podofo_shared.dir/all] Fehler 2
Makefile:127: die Regel für Ziel „all“ scheiterte
I fixed this by replacing unsigned char(...) with static_cast<unsigned
char>(...) and committed the patch in revision 1965. Could you please
verify if this is still as intended?
Thanks,
Dominik
On Fri, Feb 8, 2019 at 7:39 PM John Senneker <john.senne...@arup.com> wrote:
> Hi,
>
> Please find attached a patch containing an implementation of the Paeth
> filter, which is the only PNG filter not currently implemented by PoDoFo.
> Let me know if there’s anything that could be improved!
>
>
>
> Thanks,
>
> John Senneker
> ____________________________________________________________
> Electronic mail messages entering and leaving Arup business systems are
> scanned for viruses and acceptability of content.
> _______________________________________________
> Podofo-users mailing list
> Podofo-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/podofo-users
>
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
