On Mon, 2020-02-03 at 20:56 +0100, John Senneker wrote:
> As mentioned in ticket #17 (
> https://sourceforge.net/p/podofo/tickets/17/), auto_ptr was
> deprecated in C++11, and removed in C++17. In order to support modern
> compilers, I’ve attached a patch that replaces all usages of auto_ptr
> with unique_ptr. There were no compiler issues after dropping in
> unique_ptr, and from what I can tell there were no instances of
> copying auto_ptrs around, which is the major difference between the 2
> classes.
Hi,
this had been discussed several times on this list, I see one thread
from February 2018 (it also contains a patch) and one thread from
December 2018.
By switching unconditionally to unique_ptr you basically kill any old
compilers, not capable of the latest (or new enough) standard. It may
or may not be a problem. As it's part of the public API, it also
depends which standard the user of the library relies on.
An ideal solution, from my point of view, would be to stop using
auto_ptr in the public API completely. None of the two offered patches
do that.
Bye,
zyx
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
