Hello Podofo users, @Andreas: much thanks for your patch!
are there any plans to add this patch to the SVN repo? Because I usually generate the patches from the SVN commits for our own podofo build. Sadly I don't see any changes on the SVN since last december. Or did podofo switch to some git or something? Greetings, F. E. Am Mi., 2. Feb. 2022 um 18:14 Uhr schrieb Andreas Brzesowsky < andreas.brzesow...@dots.de>: > Hi, > > yes, it's possible to always call idn_free. Changed this with attached > patch. > But only in Windows it is necessary to use this function, because of the > heap concept of Windows. > So the same reason why use podofo_free that always calls just free in the > context of the module. > > Regards > > Andy > > Am 01.02.2022 um 08:33 schrieb zyx: > > On Mon, 2022-01-31 at 17:59 +0100, Andreas Brzesowsky wrote: > > +#ifdef _WIN32 > + // In Windows the libidn.dll could use an other heap and then > the normal free will crash. > + idn_free(password_sasl); > +#else > > Hi, > would it make sense to always call the right function, not only > sometimes? If the two can differ, no matter if only sometimes or > always, then I'd say it's better to always use the right function. > > Pity the stringprep_profile() man page does not specify what function > should be used to free the output buffer. > > It seems the idn_free() calls just free() on Linux, thus it might be > possible to use that function unconditionally. > Bye, > zyx > > > _______________________________________________ > Podofo-users mailing > listPodofo-users@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/podofo-users > > > -- > > [image: dots Software] <http://www.dots.de/en/> > > Andreas Brzesowsky > Software Developer > > dots Gesellschaft für Softwareentwicklung mbH > Schlesische Str. 27, 10997 Berlin, Germany > > Tel: +49 (0)30 695 799-33 > > andreas.brzesow...@dots.de > https://www.dots.de > > District court | Amtsgericht: Berlin Charlottenburg HRB 65201 > Managing Director | Geschäftsführer: Katsuji Kondo > > > _______________________________________________ > Podofo-users mailing list > Podofo-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/podofo-users >
_______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users