Hi zyx, just to say that these patches in particular are not really hurting the process of merging pdfmm back to PoDoFO. They can be safely merged as I will either skip or merge partially. Fix -Wmemset-elt-size warnings looks important and it seems a fix I already did myself in pdfmm[1] (I'm using assumption that WCHAR strings are utf16 in Windows, which is guaranteed).
Greetings, Francesco [1] https://github.com/pdfmm/pdfmm/blob/c6c07f29b6bf10ea2e7dee9f1eaf1ddc74e97aa6/src/pdfmm/base/PdfFontManager.cpp#L388 On Wed, 27 Apr 2022 at 07:45, zyx <z...@gmx.us> wrote: > > On Mon, 2022-04-25 at 16:25 +0200, Wolfgang Stoeggl via Podofo-users > wrote: > > here is a patch, which adds missing #include guards to the following > > header files: > > > Hi, > I believe it'll make sense to wait with patches until the sources are > moved to git and pdfmm is merged back into the PoDoFo sources [1], to > avoid merge conflicts and duplicated work. > > Similarly to your second patch (Fix -Wmemset-elt-size warnings). > > Both are kind of cleanup things, which can be void with the above work. > Just resubmit the patches (preferable in the GitHub), once the move to > git is finished. Look for such announcement here on the list. > Thanks and bye, > zyx > > [1] https://sourceforge.net/p/podofo/mailman/message/37609224/ > > > _______________________________________________ > Podofo-users mailing list > Podofo-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/podofo-users _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
