Hi POE Developers,

I´ve found a weakness in POE::Component::Client::Ident and accordingly POE/Component/Client/Ident/Agent.pm:

It doesn´t support identd answers with just "\n" as line sperator. Only "\r\n" is supported. Example:

00000000 33 34 30 34 2c 20 35 38 31 32 31 0d 0a 3404, 58 121..
00000000 33 34 30 34 2c 20 35 38 31 32 31 20 3a 20 55 53 3404, 58 121 : US
00000010 45 52 49 44 20 3a 20 55 4e 49 58 20 3a 20 76 61 ERID : U NIX : va
00000020 63 6f 0a co.



Thats not tolerant enough. The fix is easy: Remove in Line 79 the paramter 'Literal => "\x0D\x0A"', and the fallback is active ( \n\r or \r\n or \r or \n). See documentation of POE::Filter::Line at http://search.cpan.org/~rcaputo/POE-0.29/lib/POE/Filter/Line.pm :


[...]
Incoming newlines are recognized with a simple regular expression by default: |/(\x0D\x0A?|\x0A\x0D?)/|. This regexp encompasses all the variations of CR and/or LF, but it has a race condition.
[...]


Regards,
Markus Mueller

Reply via email to