avik 2005/04/21 00:43:22
Modified: src/java/org/apache/poi/hssf/usermodel HSSFWorkbook.java
src/testcases/org/apache/poi/hssf/usermodel
TestHSSFWorkbook.java
Log:
fix for not being able to name a sheet as Sheet1, with some tests
Revision Changes Path
1.39 +1 -1
jakarta-poi/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
Index: HSSFWorkbook.java
===================================================================
RCS file:
/home/cvs/jakarta-poi/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- HSSFWorkbook.java 2 Jan 2005 01:00:52 -0000 1.38
+++ HSSFWorkbook.java 21 Apr 2005 07:43:22 -0000 1.39
@@ -365,7 +365,7 @@
public HSSFSheet createSheet(String sheetname)
{
- if (workbook.doesContainsSheetName( sheetname, -1 ))
+ if (workbook.doesContainsSheetName( sheetname, sheets.size() ))
throw new IllegalArgumentException( "The workbook already
contains a sheet of this name" );
HSSFSheet sheet = new HSSFSheet(workbook);
1.4 +7 -1
jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java
Index: TestHSSFWorkbook.java
===================================================================
RCS file:
/home/cvs/jakarta-poi/src/testcases/org/apache/poi/hssf/usermodel/TestHSSFWorkbook.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- TestHSSFWorkbook.java 19 Sep 2004 02:06:54 -0000 1.3
+++ TestHSSFWorkbook.java 21 Apr 2005 07:43:22 -0000 1.4
@@ -23,7 +23,7 @@
throws Exception
{
HSSFWorkbook b = new HSSFWorkbook( );
- b.createSheet();
+ b.createSheet("Sheet1");
b.createSheet();
b.createSheet("name1");
try
@@ -56,6 +56,12 @@
b.setSheetName( 3, "name2", HSSFWorkbook.ENCODING_UTF_16 );
b.setSheetName( 3, "name2", HSSFWorkbook.ENCODING_UTF_16 );
b.setSheetName( 3, "name2" );
+
+ HSSFWorkbook c = new HSSFWorkbook( );
+ c.createSheet("Sheet1");
+ c.createSheet("Sheet2");
+ c.createSheet("Sheet3");
+ c.createSheet("Sheet4");
}
}
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
Mailing List: http://jakarta.apache.org/site/mail2.html#poi
The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
