DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=42474>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42474 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From [EMAIL PROTECTED] 2007-05-24 01:09 ------- I applied the patches. Unit tests are in src/scratchpad/testcases/org/apache/poi/hslf/usermodel/TestBugs.java 1. Incorrect matching of notes to slides My fix is a bit different from the suggested patch. To find Notes for a Slide we need to look at Slide.SlideAtom.notesId. It references the corresponding notes slide ( 0 if slide has no notes). This logic works OK to me. 2. NPE in RichTextRun.isBold() when the RichTextRun comes from a Notes model object Applied. It's possible to have null master sheet for Notes. No NPE in this case. >P.S. You will notice that with or without the patch there are some superflous >Notes being returned for Slides which have no actual Notes in PowerPoint, but >atleast with the patch Notes don't seem to get lost. I confirmed that. For the ppt from http://www.cse.lehigh.edu/~caar/marnold/presentations/vail3.ppt slides 2 and 3 don't have notes in PowerPoint but have them in HSLF. This is quite unexpected to me. Slide.SlideAtom.notesId indicates that the slide has notes. It looks like there is something else to check when linking Slides and Notes. But what? I'm leaving this riddle undiscovered. Yegor -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
