-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Levente Tamas wrote: > Hey another:
Hi, I cc the list as this may be of interest to others. > 1. This is the return packet if I want to join a table if it > doesn't exists. But you wrote into pokerpackets.py that it should > return a PacketPokerTable with serial 0 if player cannot join a > table for any reason:) > Bradley (bkuhn on IRC) is completing tests on the corresponding server code > elif packet.type == PACKET_POKER_TABLE_JOIN: table = > self.service.getTable(packet.game_id) if table: if not > table.joinPlayer(self, self.getSerial()): ! self.sendPacketVerbose(PacketPokerTable()) The ! shows that this line was not tested yet. Could you please fill a bug report with the packet sent and ping back on IRC in the next few weeks to make sure it is not overlooked ? Because the tests were not covering this case and because the clients (2D + 3D) tend to behave well, it is possible that the error handling has an error. Thanks. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH/HT18dLMyEl6F20RAjvmAJ93dExUCaKBizjtiCtli96/gMrXeACeLN/H oG3YrR2OCbPyanFNtGHOxJI= =1t0D -----END PGP SIGNATURE----- _______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
