-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, > Great, thanks. > > test.py is very useful, but it was not in the Debian > python-pypoker-eval that I used to install. May I suggest adding it > in the doc directory? > I will add it to the next release. > Also, In pokereval.py, in def poker_eval(self, *args, **kwargs): > > there is no mention of the "fill_pockets" option > > Shouldn't it be mentioned there? > The fill_pockets argument is for the winners method, not the poker_eval method. It is related to it though and the "iterations" section documents the behaviour of the poker_eval method when a placeholder (255 or __) is set instead of a card value. > > In pokereval.py in def winners(self, *args, **kwargs): The comments > reads: [...] If the keyword argument "fill_pockets" is set, remove > any pocket hand that contains a place holder (i.e. 255 or __) or > any empty pocket (i.e. []). """ > > My reading of the code says otherwise. I understand the code to do > the following: - if it is an empty poket [], it is removed, > regardless of argument - if the argument "fill_pockets" is NOT set, > and there are wildcards (255 or __) in some pocket cards, then > these pockets are removed. > > > You are absolutely correct. I modified the documentation to be a lot more verbose.
http://svn.gna.org/viewcvs/pokersource/trunk/pypoker-eval/pokereval.py?rev=3966&view=auto Do you think it will help understand the purpose of the fill_pocket argument ? > > I don't really know the C/C++ wrapping for Python, so the following > is a wild guess. When you say above that the wildcard feature was > added to the Python wrapping, you mean to the C/C++ code built on > top of the macros and compiled to create the library that the > python code calls? That may be a piece of code I'd like to give a > look to. Your interpretation is correct. And the corresponding code is here : http://svn.gna.org/viewcvs/pokersource/trunk/pypoker-eval/pypokereval.c?rev=3483&view=auto Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIRByl8dLMyEl6F20RAq8sAJ0SeyA1Wc1KaQ4KtM2tusz1XGGx/ACbBu2e 1wgyZIM3k20DR5w051cvF8o= =Ub60 -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[EMAIL PROTECTED] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;fax:+33 1 70 61 58 79 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
