-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johan Euphrosine wrote: > Hi, > > I would like to propose the attached patch for review, that add > support for authentication plugins to poker-network. > > Let me know if it deserve more love in order to get included into > trunk. Unless I'm mistaken, import in functions are frowned upon. I used it in the past but I avoid it now.
+ from pokerauth import get_auth_instance + self.poker_auth = get_auth_instance(self.db, self.settings) Other than this, it looks like a very nice contribution to pokersource. If you commit it to the trunk, I will run the tests against it and feed it to the packaging farm. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkhySKIACgkQ8dLMyEl6F23KbwCgnx/G8WlEwo4FpWigrXbKQGPU 3PoAoKcWXx0oc0eLJnL6cp0pt9ogaMsu =iZy5 -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[EMAIL PROTECTED] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;fax:+33 1 70 61 58 79 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
