-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bradley M. Kuhn wrote: > I am working on this: > http://pokersource.info/developers/specifications/earthquake.html#%5B%5Bcap%20number%20of%20players%5D%5D > > > I would have just asked Loic this on IRC, but I wanted him to see > it while I was sleeping. :) > > > I have committed r4278, which I believe implements the basics of > player capping. > > My worry currently is regarding transient tables. A few things > remain unclear to me: > > (a) First, it seems to me perhaps we should not actually ever > forbid a player from joining a transient table. Namely, if someone > has a seat in a tourney (which I believe is the ONLY use for > transient tables), they should be permitted to join the server > *regardless*. I think I'm missing something. From what I read in the code, a player will never be refused to join the table if he has a seat.
if not self.game.isSeated(client.getSerial()) and self.factory.joinedCountReachedMax() > > (b) Second, if we agree about (a), then we have to distinguish at > table-join time between people who are to be seated as they join a > transient table, and people who wish to just observe one. I note > that there are still a few places that transient table operation in > pokertable.py seems a bit strange to me, and there seems to some > sort of automatic seating at transient tables that I don't fully > understand yet. Maybe there is a misunderstanding about the logic of joining tournament tables. When the tournament table is created the players are joined with def tourneyGameFilled(self, tourney, game): (in pokerservice.py) using client.join and not table.joinPlayer (meaning your count won't be accurate in your current implementation). When a tournament table breaks (or when tables are balanced by moving players from a full table to an almost empty table) the def movePlayer(self, client, serial, to_game_id): (in pokertable.py) is called and also uses client.join to sit the player to the new table (same counting problem as above) and destroyPlayer to remove it from the old table. I hope this clarifies the tournament tables logic. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkin/BUACgkQ8dLMyEl6F21sRgCeKogG8QTjtn+phpwo2cs+ze07 wfMAoLCRkKND4vn1+O2HRvRBVtkXBT7i =cvH4 -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[EMAIL PROTECTED] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
