-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Cedric Pinson wrote: > Hi, > > Here a patch to add a packet in client side (pokerexplain.py). This > packet translate the player bet and player amount into chips stack > unit. Like bet2pot, or player2bet packet. So now each > poker_player_chips sent to the client is accompagned with a > poker_client_player_chips. The patch add the functionality and an > update of test related to update of chips of player. Your patch looks good to me. However, because it generates a number of additional packets, it should only be activated if a given bit of the explain mode is set. I suggest you wrap them in a if XXX. Note that setExplain in pokeravatar.py has a "what" argument that is not currently used. It is intended precisely for this cases. In pokernetwork/pokerpackets.py in packet PokerExplain the default is ALL. I suggest you assign do something like:
NONE = 0x0000 REST = 0x0001 CHIPSTACKS = 0x0004 ALL = REST | CHIPSTACKS I've not thought precisely about this, you will have to make adjustements, but I hope you catch the spirit. Of course, because you're not communicating with the pokerexplain thru the network, only ALL is of interest to you. By using these conditional flags, you isolate the REST clients from your modifications. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkjA660ACgkQ8dLMyEl6F23VQACgsxPz/+clHYdFy8F0WBRa6kaC 0WQAnAtHM1FI6ZXa3YWZjBoAeD0y4Tf+ =jhXi -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[EMAIL PROTECTED] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
