Hi, I would be gratefull if someone could review the patch at http://svn.gna.org/viewcvs/pokersource?view=rev&rev=5822. Comment can be added to the corresponding bug https://gna.org/bugs/index.php?13614
Here is the comment: Replace the list_hint hack with a proper patch. The general rule is that PokerExplain will always set the player_list according to the content of the InGame packet sent by the server. When an InGame packet is received, the player list is stored in the poker game. All subsequent calls to buildPlayerList ( happens when beginTurn, initRound or _talkedBlindAnte are called ) will use the stored value instead of computing it. There are three situations to consider when reasoning about the player list in the context of a client. 1) the client receives a batch stream that ends at the blind/ante stage it will receive a InGame before the Start packet and the players referenced by all the packets sent by the server up to the Stream packet will be consistent. Afterwards, if one of the players declined to pay the blinds, the player list may be recomputed by the server. It will be sent before moving to the next round and after the blind/ante are finished. 2) the client receives a batch stream that ends after pre-flop. Even if one of the players declined to pay the blind, the game history in the server has been rewritten to remove him. The InGame packet sent before the Start packet will not show the player at all. And there will be no additional InGame packet before going to pre-flop. 3) the client receives a InGame and Start packet but not in a batch stream, meaning it has seen a game already. The situation is essentially the same as 1) Thanks in advance
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[email protected] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
