-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Bradley M. Kuhn wrote: > Please find both attached and on the branch table-picker-bug-13789 @ > FIXME a fix for https://gna.org/bugs/?13789 . This patch applies > directly to trunk as of r5976. > > I plan to merge it into trunk tonight, pending dachary's review. > > Here is the commit log I expect to use: > > TablePicker() returns fullest table w/ seat that matches given criteria, > which closed bug#13789. > > This was implemented by simply adding an ORDER BY on listTables() query > to force the tables with the most players to be seen first by the > selection function, getTableBestByCriteria() which already returns when > it finds the first table that isn't full and the player has enough money > to buy in for. > > This patch is copyrighted by me and licensed AGPLv3-or-later. > > > Added ORDER BY on listTables() so that the tables with the most players > are highest in the list. The existing code does the rest. > Just one remark:
ORDER BY players desc, serial ordering by serial as a secondary key is not necessary. But not harmful either, probably just waste a little CPU. The rest looks good. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpH4VEACgkQ8dLMyEl6F203wwCfYOT/ID3ytEik75x6/CAEBDbd xVUAmgOzIr2MJzQGGT3RIyIOwYAUiydZ =nsVR -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[email protected] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
