-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> > to a conclusion that it wasn't worth doing coverage. (Do you still > feel that way, Loic? Others?): Yes, I still feel that way. > * The pokerbot* files have very incomplete coverage, but may not be > worth doing at this time: > > ../pokernetwork/pokerbot 179 0 0% > 26-257 ../pokernetwork/pokerbothandeval 248 0 0% > 21-313 ../pokernetwork/pokerbotlogic 233 53 22% > 103-105, 108-114, 117-122, 126-265, 268-273, 276-311, 314-349 > Note that there are two ways the poker bot code will evolve in the near future. First, the tomfmason patch that has been sitting for a very long time in a branch can be injected (it has better coverage, I think). Second, by the end of August Guy said he would publish a Free Software bot he has been working on this year, including an adapter for the pokersource protocol. When and if this happens we could obsolete the current bot or turn it into a test only bot (which is the reason why it was written in the first place). > * The poker client files have pretty good coverage (see my patch > posted separately as well that helps this along), but it may not be > worth completing these last few things at this time: > ../pokernetwork/OLDpokerclientpackets 393 392 99% 29 This line is worth covering and should be easy too. At some point we will decide to obsolete the old packet code that is extremely verbose in favor for the new generative method and this file will help with the transition. > ../pokernetwork/pokerclient 652 521 79% 57, > 66, 72, 78, 81, 93-94, 125, 138, 147-149, 153, 176-177, 195, 201, > 204, 207, 210-221, 231-233, 239, 242, 245, 248, 264-279, 305, 308, > 314, 326, 329, 332, 335, 338, 341-342, 345, 348, 356, 424, 426, > 438, 440, 452, 484-490, 493-507, 510-515, 523-524, 556-557, 580, > 606, 609-610, 613-615, 628, 643-644, 664, 763, 774, 776, 781-786, > 789-794, 797-798, 806-808, 811-816, 823, 846, 858, 870, 873, 877, > 904, 915, 960 > > > This leaves the second group, which aare files, that I am unsure if > we should finish coverage on. The only one I am certain needs > complete coverage is pokerlock. How do folks feel about the other > files? Are they important enough to demand full coverage? > > ../pokernetwork/countfilter 16 0 0% 21-41 > Yes : however I think it already is covered and the reason why it does not show is because of a flaw in the coverage code. The file is dynamically loaded and counting is done wrong because of that. I realize this is crappy bug report ;-) We should probably check if there is another more modern way to compute the coverage and hope it does not have the same problems. > ../pokernetwork/dispatch 16 11 68% 48-52 > No (client only). > ../pokernetwork/nullfilter 2 0 0% 23-24 > Yes : same as countfilter. > ../pokernetwork/pokerchildren 245 192 78% > 28-30, 50-77, 93-95, 110, 160, 173, 192-196, 199-200, 205, 214-215, > 237-242, 270-276, 281, 290-292, 300, 320 No (client only). > ../pokernetwork/pokerlock 103 102 99% 147 Yes. > ../pokernetwork/proxyfilter 79 77 97% 37, > 110 Yes. > ../pokernetwork/upgrade 163 132 80% > 29-30, 118-119, 131-132, 142-143, 154-159, 174, 193-198, 203, > 218-222, 225-230 > No (client only). > Everything not mentioned here is 100% covered in poker-network. Congratulations :-) Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpO/C0ACgkQ8dLMyEl6F22FwwCffQJQ1cG+SLPCRftvpW9M2YMo fPwAoL+VBo+USoTYPqEmdty7JIeWGBf5 =FEvg -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[email protected] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
