-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johan Euphrosine wrote: > Hi, > > Feel free to review the attached patch, before I commit it to > pokersource trunk: > > 2009-07-17 Johan Euphrosine <[email protected]> > > * database/schema.sql.in: * pokernetwork/pokerservice.py > (PokerService.chatMessageArchive): * tests/test-pokerservice.py.in > (PokerServiceTestCase.test25_chatMessageArchive): * > pokernetwork/pokertable.py (PokerTable.chatPlayer): * > tests/test-pokertable.py.in > (PokerTableTestCase.test10_info_and_chat): add database archiving > of chat messages. > > This patch is copyrighted by me and licensed AGPLv3-or-later. The patch looks fine to me except for this:
+CREATE TABLE chat_messages ( + serial INT UNSIGNED NOT NULL AUTO_INCREMENT, there is no need for a serial for each message. Cheers -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkpgc1MACgkQ8dLMyEl6F20TTQCbBCy/RXwRMojiop7KdrmUNxNz bscAniN5Uejm8+QIWzo+pQzdgRYlIh/N =snPe -----END PGP SIGNATURE-----
begin:vcard fn:Loic Dachary n:Dachary;Loic org:pokersource adr:;;12 bd Magenta;Paris;;75010;France email;internet:[email protected] title:Senior Developer tel;work:+33 9 51 18 43 38 tel;cell:+33 6 64 03 29 07 x-mozilla-html:FALSE url:http://dachary.org/ version:2.1 end:vcard
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
