Today, Loic asked to check what happens when bots are broke,
* DONE check bot rebuy issues CLOCK: [2010-04-02 Fri 09:23]--[2010-04-02 Fri 09:41] => 0:18 http://drupal-dev.pokersource.info/trac/ticket/365 SELECT * FROM user2money WHERE user_serial = 2699; | 2699 | 1 | 0 | 0 | 0 | SELECT * FROM user2money WHERE user_serial = 381; | 381 | 1 | 0 | 0 | 0 | 2010-04-01 16:21:16+0000 [PokerBotProtocol,client] ERROR: type = ERROR(53) serial = 381 game_id = 1 message = no message, code = 0, other_type = POKER_REBUY Since rebuy is disabled on os_poker in favor of daily chips allocation, bot are unable to rebuy when broke. One solution would be to provided plenty of money to bot initaly, or throught a cron script. Another solution would be to tweak pokerauthnopassword (only used by the bots) to allocate chips on connection. I also had a quick chat with ckudige about pushing yesterday changes to pb: * DONE chat ckudige about pb push CLOCK: [2010-04-02 Fri 09:02]--[2010-04-02 Fri 09:09] => 0:07 Unfortunatly, we had a missunderstanding about when the changes needed to be pushed, I was expecting them to be pushed today, while ckudige was planning to push them on monday. We then agreed to try pushing changes together on pb today while nobody is playing. * DONE review change before pushing on pb :CLOCK: CLOCK: [2010-04-02 Fri 13:57]--[2010-04-02 Fri 14:41] => 0:44 CLOCK: [2010-04-02 Fri 12:01]--[2010-04-02 Fri 13:33] => 1:32 CLOCK: [2010-04-02 Fri 09:48]--[2010-04-02 Fri 10:46] => 0:58 :END: I merged rikeko's change from drupal-demo/usr/src/pb_jpoker. I cleared outstanding uncommitted merges on drupal-demo/usr/src/pb_jpoker with: hg update -C 329 I checked that gadget automated tests pass: http://drupal-demo.pokersource.info/pb_jpoker/test-poker.html http://drupal-demo.pokersource.info/pb_jpoker/test-poker-opensocial.html I fixed jpoker test suite: http://drupal-kez.pokersource.info/hg/pb_jpoker/jpoker/rev/095c1552734c And revert 'de' translation upstream changes to prevent regression: http://drupal-kez.pokersource.info/hg/pb_jpoker/jpoker/rev/5a2e29c68d72 So that jpoker test suite only display expected failure: - disabled error handling - i18n string specifics http://drupal-demo.pokersource.info/pb_jpoker/jpoker/jpoker/test-jpoker.html I performed visual check *outside* drupal for the following tickets #192, #304, #307, #308: http://drupal-demo.pokersource.info/pb_jpoker/skin/table.html#jpoker_58_tourneyRank http://drupal-demo.pokersource.info/pb_jpoker/skin/tourney.html#jpoker_81_3_tourneyDetailsRegularRunningWithPager http://drupal-demo.pokersource.info/pb_jpoker/skin/tourney.html#jpoker_82_2_tourneyDetailsRegularCompletedWithPager http://drupal-demo.pokersource.info/pb_jpoker/skin/tourney.html#jpoker_81_3_tourneyDetailsRegularRunningWithPager I fixed an issue with jpoker_tourney_details_table overflow: http://drupal-kez.pokersource.info/hg/pb_jpoker/rev/fc40ba3a7731 I fixed a regression in tourneyDetails permalinks: http://drupal-kez.pokersource.info/hg/pb_jpoker/rev/12faef9373d6 I performed visual check *inside* drupal for the following tickets #192, #304, #307, #308, by playing a sitngo tournament: mysql> INSERT INTO `tourneys_schedule` ( `name`, `description_short` , `description_long` , `players_quota` , `variant` , `betting_structure` , `seats_per_game` , `currency_serial` , `buy_in` , `rake` , `sit_n_go` , `start_time` , `register_time` , `respawn` , `respawn_interval` ) VALUES ( 'sitngo2', 'Sit and Go 2 players, Holdem', 'Sit and Go 2 players', '2', 'holdem', 'level-15-30-no-limit', '2', 1, '300000', '0', 'y', '0', '0', 'y', '0' ); I found the following issues: "tourneyDetails table selection feedback is cleared by tourneyDetails update" http://drupal-dev.pokersource.info/trac/ticket/367 "sitngo 2 players server Traceback when winning allin" https://gna.org/bugs/?15766 chandan performed visual checks on IE7 and IE8 and found the following issues with IE8: http://drupal-dev.pokersource.info/trac/ticket/304#comment:10 http://drupal-dev.pokersource.info/trac/ticket/307#comment:5 We identified these issues are not regression: http://pb.pokersource.info/pb_jpoker/skin/tourney.html#jpoker_85_1_tourneyDetailsRegularRegisteringWithPagerRegister But were unable to reproduce them *inside* drupal: http://poker.playboy.de/?q=node#tourney_serial=1388 We agreed to delay the push, until we are able to reproduce these issues within drupal. * DONE run skin cases within drupal CLOCK: [2010-04-02 Fri 14:36]--[2010-04-02 Fri 17:22] => 2:46 I made new gadget named jpoker-opensocial-skin.xml: http://drupal-kez.pokersource.info/hg/pb_jpoker/rev/b6661c3f0661 Mongolito404 helped me to make a new drupal module named os_poker_skin to render the gadget skin cases: http://drupal-kez.pokersource.info/hg/os_poker/rev/196769c9d3c3 After installing the module, and importing the gadget from: http://drupal-demo.pokersource.info/pb_jpoker/jpoker-opensocial-skin.xml We were able to run tourney skin case within drupal using the following urls: http://drupal-demo.pokersource.info/drupal6/?q=skin/gadget Note there is also partial support for permalinks: http://drupal-demo.pokersource.info/drupal6/?q=skin/gadget#jpoker_81_3_tourneyDetailsRegularRunningWithPager Now that we are able to reproduce skin cases within drupal, we should be able to confirm if the following IE8 skinning issues are reproducible within drupal, and then push changes related to z2#192 #304 #307 and #308 to pb: http://drupal-dev.pokersource.info/trac/ticket/304#comment:10 http://drupal-dev.pokersource.info/trac/ticket/307#comment:5 #+BEGIN: clocktable :maxlevel 2 :scope file Clock summary at [2010-04-02 Fri 17:43] | L | Headline | Time | |---+-----------------------------------------+--------| | | *Total time* | *6:25* | |---+-----------------------------------------+--------| | 1 | DONE check bot rebuy issues | 0:18 | |---+-----------------------------------------+--------| | 1 | DONE chat ckudige about pb push | 0:07 | |---+-----------------------------------------+--------| | 1 | DONE review change before pushing on pb | 3:14 | |---+-----------------------------------------+--------| | 1 | DONE run skin cases within drupal | 2:46 | #+END: -- Johan Euphrosine (proppy) <[email protected]> Development and services around Free Software http://www.aminche.com/
signature.asc
Description: Digital signature
_______________________________________________ Pokersource-users mailing list [email protected] https://mail.gna.org/listinfo/pokersource-users
