> Second one is a fix for the CONNECT request (https handling) when
> proxyOffline is true, to avoid a long timeout.

Applied, thanks.

> First one is using a kill -HUP for toggle the proxyOffline mode.

Rejected.  You would need to test whether we're daemonising, since
catching SIGHUP when not daemonising causes processes to hang around.
But then, you'd need to check whether we're being run from runit or
something similar (systemd?).  So I'd suggest avoiding this complexity
by not catching SIGHUP.

Especially since there's already a way to switch a running polipo
offline:

  $ wget --post-data='proxyOffline=false' http://localhost:8123/polipo/config?

(Yes, I know, it fails in the current head, which is the main blocker for
releasing 1.0.5.)

--Juliusz

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users

Reply via email to