Thanks. Could you please resubmit with the following changes?
> @@ -1,9 +1,9 @@
> -PREFIX = /usr/local
> +PREFIX = .
> BINDIR = $(PREFIX)/bin
> MANDIR = $(PREFIX)/man
> INFODIR = $(PREFIX)/info
> -LOCAL_ROOT = /usr/share/polipo/www
> -DISK_CACHE_ROOT = /var/cache/polipo
> +LOCAL_ROOT = ./www
> +DISK_CACHE_ROOT = ./polipo
Don't do that. The default Makefile should be set up for Unix.
> -# EXE=.exe
> -# LDLIBS = -lwsock32
> +EXE=.exe
> +EXTRA_DEFINES = -DWIN32 -DHAVE_IPv6 -DWINVER=0x0601
> +LDLIBS = -lws2_32 -lwsock32
As above, leave it commented out.
Additionally, please don't add HAVE_IPv6 on the command line -- just
modify the polipo.h file.
> +#ifndef WIN32:
> #ifdef EAI_NODATA
> case EAI_NODATA:
> #endif
> +#endif
Why is that necessary? Isn't the #ifdef EAI_NODATA enough?
> +#include <winsock2.h>
> +#include <ws2tcpip.h>
> +/*#include <Wspiapi.h>*/
Why the commented-out line?
> +#ifdef __MINGW32__
> #define POLLIN 0x0001 /* There is data to read */
> #define POLLPRI 0x0002 /* There is urgent data to read */
> #define POLLOUT 0x0004 /* Writing now will not block */
> #define POLLERR 0x0008 /* Error condition */
> #define POLLHUP 0x0010 /* Hung up */
> #define POLLNVAL 0x0020 /* Invalid request: fd not open */
Why is that? Please add a comment to explain.
> +static int
> +inet_pton( int family, const char * addr, void * dst )
> + {
> + struct sockaddr_storage ss;
> ...
Four spaces per indentation please, no tabs.
Other than these small details, I'll be happy to apply your patch.
Thanks,
-- Juliusz
------------------------------------------------------------------------------
Why Cloud-Based Security and Archiving Make Sense
Osterman Research conducted this study that outlines how and why cloud
computing security and archiving is rapidly being adopted across the IT
space for its ease of implementation, lower cost, and increased
reliability. Learn more. http://www.accelacomm.com/jaw/sfnl/114/51425301/
_______________________________________________
Polipo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/polipo-users
