2008/8/21 David Zeuthen <[EMAIL PROTECTED]>: > On Thu, 2008-08-21 at 01:44 +0200, Michael Biebl wrote: >> 2008/8/20 David Zeuthen <[EMAIL PROTECTED]>: >> > The GNOME release team requested a PolicyKit-gnome release for GNOME >> > 2.24 that didn't depend on libsexy. So I rolled a new one; instead >> > there's a dependency on recent GTK+ which also allowed me to cull the >> > GnomeVFS dependency. >> > o Avoid libsexy dep; ship with local copies of SexyURLLabel >> >> >> src/polkit-gnome-auth-dialog.c still includes <libsexy/sexy.h>. >> Is that an oversight? > > Yeah. Meaning one still need libsexy headers (but only that) to build > it. Does s/<libsexy/sexy.h>/"sexy-url-label.h"/ fix it? If so, I'll do a > 0.9.2 release.
I also had to change the sexy-url-label.c files to include "sexy-url-label.h". With the attached patch I no longer need the libsexy headers installed. I was just wondering if it would make sense to move the libsexy sources into a convenience lib instead of copying it twice (into src and tools). What do you think? Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
Index: src/polkit-gnome-auth-dialog.c =================================================================== --- src/polkit-gnome-auth-dialog.c (Revision 68) +++ src/polkit-gnome-auth-dialog.c (Arbeitskopie) @@ -32,7 +32,6 @@ #include <stdlib.h> #include <pwd.h> #include <errno.h> -#include <libsexy/sexy.h> #include <gconf/gconf-client.h> #include <glib/gi18n-lib.h> @@ -40,6 +39,7 @@ #include <dbus/dbus-glib.h> #include <dbus/dbus-glib-lowlevel.h> +#include "sexy-url-label.h" #include "polkit-gnome-auth-dialog.h" struct _PolkitGnomeAuthDialogPrivate Index: src/sexy-url-label.c =================================================================== --- src/sexy-url-label.c (Revision 68) +++ src/sexy-url-label.c (Arbeitskopie) @@ -18,11 +18,12 @@ * Free Software Foundation, Inc., 59 Temple Place - Suite 330, * Boston, MA 02111-1307, USA. */ -#include <libsexy/sexy-url-label.h> #include <gtk/gtk.h> #include <string.h> #include <stdio.h> +#include "sexy-url-label.h" + #define SEXY_URL_LABEL_GET_PRIVATE(obj) \ (G_TYPE_INSTANCE_GET_PRIVATE((obj), SEXY_TYPE_URL_LABEL, \ SexyUrlLabelPrivate)) Index: tools/sexy-url-label.c =================================================================== --- tools/sexy-url-label.c (Revision 68) +++ tools/sexy-url-label.c (Arbeitskopie) @@ -18,11 +18,12 @@ * Free Software Foundation, Inc., 59 Temple Place - Suite 330, * Boston, MA 02111-1307, USA. */ -#include <libsexy/sexy-url-label.h> #include <gtk/gtk.h> #include <string.h> #include <stdio.h> +#include "sexy-url-label.h" + #define SEXY_URL_LABEL_GET_PRIVATE(obj) \ (G_TYPE_INSTANCE_GET_PRIVATE((obj), SEXY_TYPE_URL_LABEL, \ SexyUrlLabelPrivate))
_______________________________________________ polkit-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/polkit-devel
