Brad Hards wrote:
On Tuesday 12 December 2006 14:23, Rex Dieter wrote:
Cleanup of the m4 code.
OK, easy,
rm -f m4/qt.m4
(:
You don't want Qt3 poppler bindings any more?
:-?
My patch used pkg-config for qt3 too. Though, not everyone likely has
pkg-config and/or qt properly configured for that, it would likely break
previously working setups if the legacy config checks for qt3 were
dropped. ):
I'll respin a new patch that simply prefers pkg-config, and falls back
to the old checks in case of failure. Does that sound (more) acceptable?
Also, can you check that the unittests build and pass with your patch? I
had to do some change to the linker lines, but I don't remember if that
was for the PKG_CONFIG stuff, or because I merged the tests for Qt and
QtTest together (because QtTestLib was included into Qt 4.1, so it didn't
make much sense to test separately at this stage).
I have yet to confirm it, but the tests should be better off with my
approach, since I kept the QtTest bits separate instead of lumping it
together with the other libs as you did.
Test, please.
will do.
-- Rex
_______________________________________________
poppler mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/poppler
