On Fri, 2020-11-20 at 13:29 +0800, Kevin Lo wrote:

> hw-probe could run on non-x86 architectures.
> Tested on arm64 [1] and octeon [2].
[..]
> +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386"
> +RUN_DEPENDS += sysutils/dmidecode
> +.endif

Hmm, although dmidecode does only package for i386 and amd64 on OpenBSD,
dmidecode is also available for ia64 and arm64 in principle.

OTOH, dmidecode requires kern.allowkmem=1 in securelevel=0, which at
least I do not usually do. So I thought shortly about completely
removing the dependency and adding a pkg-readme.

But finally, hw-probe 'as-is' tests for the availability of dmidecode
exactly on i386 and amd64 BSDs, which is reflected in your patch.

So for me it's OK, I'd say.

Reply via email to