I won’t object. :)

tux0r

> On Freitag, Nov. 18, 2022 at 11:24 AM, Omar Polo <[email protected] 
> (mailto:[email protected])> wrote:
> On 2022/11/18 10:07:06 +0000, Stuart Henderson <[email protected]> wrote:
> > On 2022/11/18 10:27, Omar Polo wrote:
> > > - CXXFLAGS="${CXXFLAGS}" \
> > > - CPPFLAGS="${CPPFLAGS}"
> > > +CFLAGS += -Dunix
> > > +LDFLAGS += -lm
> > > +
> > > +USE_WXNEEDED = Yes
> > >
> > > -CPPFLAGS += -Dunix
> > > -USE_WXNEEDED= Yes
> > > +do-build:
> > > + cd ${WRKSRC} && ${SET_ENV} ${MAKE_ENV} \
> > > + ${CXX} ${CFLAGS} -o zpaqfranz zpaqfranz.cpp ${LDFLAGS}
> >
> > CPPFLAGS is more correct for -D really. But if you're running ${CXX}
> > directly I wouldn't bother with the indirection and just put -Dunix
> > on the command line.
>
> right. i did the same with -lm and LDFLAGS
>
> > C++ -> should pass CXXFLAGS not CFLAGS.
>
> Ops! to be fair, initially i typed ${CC} too out of habit :)
>
> here's a fixed diff, thanks for checking!
>
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/archivers/zpaqfranz/Makefile,v
> retrieving revision 1.6
> diff -u -p -r1.6 Makefile
> --- Makefile 6 Sep 2022 07:07:39 -0000 1.6
> +++ Makefile 18 Nov 2022 10:19:52 -0000
> @@ -2,28 +2,26 @@ COMMENT = journaling archiver for increm
>
> GH_ACCOUNT = fcorbelli
> GH_PROJECT = zpaqfranz
> -GH_TAGNAME = 55.14
> +GH_TAGNAME = 56.1
>
> CATEGORIES = archivers
> MAINTAINER = tux0r <[email protected]>
>
> -# Public Domain
> +# various: public domain, MIT, zlib, BSD 2-clause, Apache 2.0
> PERMIT_PACKAGE = yes
>
> -FIX_CRLF_FILES = Makefile zpaqfranz.cpp
> -
> COMPILER= base-clang ports-gcc base-gcc
>
> WANTLIB = ${COMPILER_LIBCXX} c m
>
> -MAKE_FLAGS += CXX="${CXX}" \
> - CXXFLAGS="${CXXFLAGS}" \
> - CPPFLAGS="${CPPFLAGS}"
> +USE_WXNEEDED = Yes
>
> -CPPFLAGS += -Dunix
> -USE_WXNEEDED= Yes
> +do-build:
> + cd ${WRKSRC} && ${SET_ENV} ${MAKE_ENV} \
> + ${CXX} ${CXXFLAGS} -Dunix -o zpaqfranz zpaqfranz.cpp -lm
>
> -post-install:
> +do-install:
> + ${INSTALL_PROGRAM} ${WRKSRC}/zpaqfranz ${PREFIX}/bin/
> ${INSTALL_MAN} ${WRKSRC}/man/zpaqfranz.1 ${PREFIX}/man/man1/
>
> do-test:
> Index: distinfo
> ===================================================================
> RCS file: /home/cvs/ports/archivers/zpaqfranz/distinfo,v
> retrieving revision 1.4
> diff -u -p -r1.4 distinfo
> --- distinfo 5 Sep 2022 20:14:47 -0000 1.4
> +++ distinfo 18 Nov 2022 08:48:47 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (zpaqfranz-55.14.tar.gz) = 
> NQu4rTUPFK5MEOypueG2kaAU4dXUGG54vI2ajgTMF6M=
> -SIZE (zpaqfranz-55.14.tar.gz) = 10588313
> +SHA256 (zpaqfranz-56.1.tar.gz) = PQNwOeVt0Zvw/xqhZy42NRrptFONopXGp2ylXhBWmY0=
> +SIZE (zpaqfranz-56.1.tar.gz) = 3738177

Attachment: signature.asc
Description: PGP signature

Reply via email to