Benjamin Stürz <[email protected]> writes:
> Hi Omar, > > On 30.05.23 19:03, Omar Polo wrote: >> Hello, >> I remember that when I started using OpenBSD I kind of missed >> lsblk... >> Now I wouldn't look back probably, but it could be nice for newcommers >> (at least :-) > Yeah, that's the reason why I made this tool. > Using sysctl + disklabel + df is a little annoying. > >> Bummer that it needs superuser privileges to show the list, but I >> haven't looked at how it's implemented so don't know. > Actually if you do > # chgrp operator /usr/local/sbin/lsblk > # chmod g+s /usr/local/sbin/lslbk Adding a setguid program even in ports seems like a bad idea to me. > or > # make unroot > you can run it as a normal user. > > But I didn't know if I should include it in the port. > >> The port itself looks fine to me, except for the permissions of >> distinfo and PLIST... All files should be 0644 and directories 0755. > Fixed, the problem was my umask of 027. > >> No need to send an updated tarball just for this however, whoever will >> import it can easily fix it. > Did it anyway + for the reasons below. > >> OK op@ to import with perms fixed. >> Now, some misc nits that don't really affect the port: >> - you could set yourself as MAINTAINER for the port. It is not >> required of course, but seems you seem to be the upstream too >> you're qualified enough I'd say ;-) > Done > >> - I'd drop -Werror from release tarballs. While it is super-useful >> during development, it is a super-pita for packagers when the C >> compiler gets updated. > Done > > Best regards, > Benjamin Stürz > > [2. application/octet-stream; lsblk-1.2.3.tgz]...
