Hi Anil,
> | NOTRACK -> i0 b "notrack" (* TODO does masm support this? *)
Seems it doesn't :-)
gmake[4]: Entering directory '/home/ports/ocaml/ocaml/stdlib'
OCAMLOPT camlinternalFormatBasics.cmx
/tmp/camlasm69ee74.s:83:2: error: invalid instruction mnemonic 'notrack'
notrack
^~~~~~~
/tmp/camlasm69ee74.s:512:2: error: invalid instruction mnemonic 'notrack'
notrack
^~~~~~~
/tmp/camlasm69ee74.s:942:2: error: invalid instruction mnemonic 'notrack'
notrack
^~~~~~~
File "/home/ports/ocaml/ocaml/stdlib/camlinternalFormatBasics.ml", line 1:
Error: Assembler error, input left in file /tmp/camlasm69ee74.s
cheers,
Volker
On Thu Sep 7, 2023 at 9:37 AM CEST, Anil Madhavapeddy wrote:
> Would anyone with an IBT-enabled x86_64 be able to run a test for me on an
> OCaml tree to see if the patch works? (my hardware is still two weeks away
> from delivery)
>
> $ git clone https://github.com/avsm/ocaml -b btcfi
> $ cd ocaml && gmake -j world.opt && gmake tests
>
> It just adds notrace to the jump points. I think arm64 needs destination
> labels instead; will do that later.
>
> Anil