On Sun, Nov 12, 2023 at 11:54:33AM -0500, Thomas Frohwein wrote: > On Sun, Nov 12, 2023 at 04:58:34PM +0100, Theo Buehler wrote: > > And now with correct MAINTAINER address :) > > > > On Sun, Nov 12, 2023 at 04:55:16PM +0100, Theo Buehler wrote: > > > Build machines install and uninstall packages all the time. When > > > audio/dumb is installed while games/dsa-doom is installed, it picks it > > > up. > > > > > > -- Found DUMB: > > > optimized;/usr/local/lib/libdumb.a;debug;/usr/local/lib/libdumbd.a > > > > > > Since the dependency is not registered as part of LIB_DEPENDS, it can > > > be uninstalled at any time. This happened in my last bulk build and > > > then resulted in a build failure: > > > > > > /tmp/pobj/dsda-doom-0.26.2/dsda-doom-0.26.2/prboom2/src/MUSIC/dumbplayer.c:77:10: > > > fatal error: 'dumb.h' file not found > > > #include <dumb.h> > > > ^~~~~~~~ > > > 1 error generated. > > > ninja: build stopped: subcommand failed. > > > > > > There are two ways to fix this: either add audio/dumb as a LIB_DEPENDS + > > > WANTLIB and check that it works or disable it in some way or the other > > > in the configure script. > > > > > > Full log attached.
Yeah, I did not. > I think disabling dumb with the diff below is the easiest solution, but > as I don't use dsda-doom, I am not sure what the ramifications are for > running mods with it. The problem with enabling libdumb correctly and > adding it as dependency is that it is statically linked and there is no > libdumb.so.M.m which makes it harder to track when the port needs to be > bumped... To my knowledge, it would require a BUILD_DEPENDS on > audio/dumb and then remembering to bump dsda-doom whenever audio/dumb > changes. Yes, right. That bumping would usually be handled with a comment at the top of the Makefile of audio/dumb, which is very easy to overlook and fragile, especially if a port doesn't have a maintainer who cares. > To avoid the headache, I propose disabling dumb at this point. ok? Sounds good to me. ok tb > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/games/dsda-doom/Makefile,v > retrieving revision 1.1.1.1 > diff -u -p -r1.1.1.1 Makefile > --- Makefile 27 Jul 2023 20:50:30 -0000 1.1.1.1 > +++ Makefile 12 Nov 2023 16:50:52 -0000 > @@ -3,6 +3,7 @@ COMMENT = fork of prboom+ with a focus > GH_ACCOUNT = kraflab > GH_PROJECT = dsda-doom > GH_TAGNAME = v0.26.2 > +REVISION = 0 > > CATEGORIES = games x11 > MAINTAINER = Lucas de Sena <[email protected]> > @@ -25,7 +26,8 @@ LIB_DEPENDS = archivers/libzip \ > devel/sdl2-image > > # requires fluidsynth v2.0, currently we have 1.x > -CONFIGURE_ARGS = -DWITH_FLUIDSYNTH=OFF > +CONFIGURE_ARGS = -DWITH_DUMB=OFF \ > + -DWITH_FLUIDSYNTH=OFF > > MODCMAKE_LDFLAGS = -L${X11BASE}/lib -L${LOCALBASE}/lib > CFLAGS += -I${X11BASE}/include -I${LOCALBASE}/include
