Frederic Cambus wrote (2023-11-13 12:58 CET): > On Sat, Nov 11, 2023 at 07:02:58PM +0100, Stefan Hagen wrote: > > > > fclones is a command line utility that identifies groups of identical > > > files > > > and gets rid of the file copies you no longer need. It comes with plenty > > > of > > > configuration options for controlling the search scope and offers many > > > ways > > > of removing duplicates. For maximum flexibility, it integrates well with > > > other Unix utilities like find and it speaks JSON, so you have a lot of > > > control over the search and cleanup process. > > > > finally something that's a bit more clever than fdupes. I wish it had a > > manpage instead of making me jump through all commands with the -h flag. > > But that's the world we live in... > > > > The port looks good. You could replace the GH_* lines with the new > > DIST_TUPLE (and recreate distinfo): > > > > DIST_TUPLE = github pkolaczk fclones v0.34.0 . > > Good point, thanks, I moved DIST_TUPLE a bit upper in the Makefile in > the position of the previous GH_ variables. > > (We should probably add a DIST_TUPLE entry in Makefile.template to > standardize positioning).
You're probably right. I sent a diff to add it to the Makefile. > > Regarding the patch... is this the rust way to find `basename $0`? > > > > If this is the case, why don't you just patch it to: > > > > program_name: "fclones".to_string(), > > I used the same mechanism as in the lang/deno patches but I agree that > it's easier to simply hardcode the string. > > I regenerated the patch to remove the "use std::path::PathBuf;" part > which isn't required anymore. > > > 1 (of 165) test fails: > > test dedupe::test::test_partition_respects_creation_time_priority ... FAILED > > Also fails here, I'm not sure what to do about this. > > New tarball attached. Looks good. OK for import sdk@
