On Thu, December 14, 2023 21:27, Klemens Nanni wrote: > On Thu, Dec 14, 2023 at 11:10:01AM +0300, Kirill Bychkov wrote: >> On Fri, December 1, 2023 13:27, Kirill Bychkov wrote: >> > Hi! >> > Attached diff adds Qt6 FLAVOR to qtkeychain. It is >> > needed for upcoming net/owncloudclient update. >> > OK? >> >> Ping >
Hi!
> The result looks fine, but you have quite a few (trailing) space/tab issues.
> Should keychain,qt6 be hooked up?
When owncloud client update will be ready- surely
>
> Some lines move around without changing.
I've moved them back to reduce diff.
>
> Two unconditional SHARED_LIBS seems off; you can use LIBNAME_L, either in
> FLAVOR blocks for unique versions or outside if qt6 can start at 2.1.
>
> LIBNAME_L could be ${LIBNAME:L} instead of duplicating the string.
Fixed, thanks.
> You could also reuse QT to pull common lines out of the FLAVOR blocks.
>
It will make things complicated.
Attached diff with fixes and REVISION bump.
qtkeychain-qt6.diff
Description: Binary data
