On 2024/01/27 12:04, Laurent Cheylus wrote: > Hi, > > proposal to import sysutils/btop. > > btop is a ressource monitor (written in C++) for CPU, processes, memory, > disks and network => https://github.com/aristocratos/btop > With the work of Jos Dehaes (https://github.com/joske), OpenBSD is now > supported by btop with version 1.3.0. > > With the recent commits by robert@ to update libc++ and libc++abi, it's > possible to build it with clang++ v16.0.6 (C++23 necessary). > > In Makefile, I created a specific install step to install only binary and > themes => don't install btop.desktop and PNF/SVG files for icon. It allows > not to have a RDEP on gtk4. > > Build and functional tests OK on current/amd64. > > Tests/comments welcome and please commit if OK. > > Laurent > >
The patch fails to apply. Also it patches the install target, which is overridden with do-install anyway. Patching file Makefile using Plan A... Hunk #1 succeeded at 57 with fuzz 2 (offset 11 lines). Hunk #2 succeeded at 136 (offset -17 lines). Hunk #3 failed at 211. Hunk #4 succeeded at 287 with fuzz 1 (offset 27 lines). Hunk #5 failed at 327. 2 out of 5 hunks failed--saving rejects to Makefile.rej Don't force disable stripping, you're using INSTALL_PROGRAM so it will be stripped automatically if appropriate (i.e. stripped normally, not stripped if doing a build with DEBUG set). You're just using the OS compiler, no need for lang/clang MODULES or MODCLANG_VERSION. I'd do this: -COMPILER = base-clang - -MODULES = lang/clang -MODCLANG_VERSION = 16 +# C++23 +COMPILER = base-clang The README should go in share/doc/btop not share/btop. (I haven't unpicked the patch so not tried building).
