Thank you so much, Omar! You're the best thank you for addressing the
issues in my code. It's working well on my machine! Testing on i386 in a
bit.
- could use DIST_TUPLE (+ make makesum)
Good to know about this. I copy-pasted from dhewm3 instead of looking at
the template which has DIST_TUPLE.
- why set COMPILER? Haven't tested with gcc4, but a quick scan didn't
reveal something that it shouldn't handle. Maybe there's a chance
it'll work :)
I was filling out the template and now that I'm reading again it looks
like COMPILER is only for C++? I guess I didn't really understand that
and I just filled it out.
- sdl2 and sdl2-image are only LIB_DEPENDS, no need to set them
BUILD_DEPENDS
What's the difference between LIB_DEPENDS and BUILD_DEPENDS and WANTLIB?
Sorry I got confused about that.
- it still needs bash as build depends
- we can simplify do-build by using ALL_TARGET
Good to know thank you I didn't know about this! I'm not familiar with C
build systems so still learning!
- in the readme suggesting to run firefox /usr/local/share/... is not
going to work: most browsers can only read /tmp/ and ~/Downloads by
default on OpenBSD. I'm personally using python3 -m http.server as a
quick way to access these HTML files, not sure we can suggest it in
the README however... Not a huge deal however.
I think this works, actually! /usr/local/share is read-only in
/etc/firefox/unveil.main and /etc/iridium/unveil.main by default so
people should be able to read the files there!
I'm attaching a diff against your makefile and an updated tarball with
the other patches. With this it builds fine and tests are fully
passing. I can also run the program and some of the installed examples.
Still have to really dive in it however :)
Thank you so much again I'm learning a lot here.
--
Jag Talon (he/him)
https://jagtalon.net/
https://weirder.earth/@jag
https://aangat.lahat.computer/
