On 2024/08/28 07:27:27 -0400, Josh Grosse <[email protected]> wrote:
> This net/transmission update has been posted multiple times, starting
> in June. Tested by me and by Lucas Gabriel Vuotto.
>
> Included in this diff is an update to net/miniupnp/libnatpmp, which
> fixes an rtable issue with net/transmission that was reported last year,
> debugged and resolved upstream by Lucas at the end of July.
>
> Lucas has been bumping this diff weekly. It'd be wonderful if this
> could be reviewed, prior to the tree getting locked.
>
> Thanks in advance!
libnatpmp looks fine to me, with minor nits inline below. I haven't
tested the other consumer (net/bitcoin), but this only brings a tiny
change for cmake and lucas' change, so I don't expect fallout :)
I don't run transmission anymore, but the diff looks fine to me and it's
a bugfix release. Glanced over the diff between 4.0.5 and 4.0.6
upstream.
> diff --git net/miniupnp/libnatpmp/Makefile net/miniupnp/libnatpmp/Makefile
> index 43b62e7c1a1..0a87b49cfb7 100644
> --- net/miniupnp/libnatpmp/Makefile
> +++ net/miniupnp/libnatpmp/Makefile
> @@ -1,7 +1,7 @@
> COMMENT = NAT Port Mapping Protocol client library
>
> -DIST_TUPLE = github miniupnp libnatpmp
> f2433bec24ca3d3f22a8a7840728a3ac177f94ba .
> -PKGNAME = libnatpmp-20240116
> +DIST_TUPLE = github miniupnp libnatpmp
> 8257134a5dcb077e40db1946554d676e444406e4 .
> +PKGNAME = libnatpmp-20240803
^^
shouldn't this be 04 instead of 03? lucas' commit is of the 2nd and was
merged on the 4th.
While here I'd also remove the commented ${INSTALL_MAN_DIR} since it's
pointless
: post-install:
:- #${INSTALL_MAN_DIR} ${PREFIX}/man/man1
: ${INSTALL_MAN} ${WRKSRC}/natpmpc.1 ${PREFIX}/man/man1/natpmpc.1
with these, ok op@ for both
