Thank you for reviewing the port and for simplifying it! Patched port is attached.
If anyone is interested in testing the runtime, steps
are:
- install hatop from ports, it will install haproxy
as well
- add following lines to /etc/haproxy/haproxy.cfg
under "global" section:
stats socket /var/run/haproxy.sock mode 666 level admin
stats timeout 2m
- restart haproxy:
# /etc/rc.d/haproxy restart
- launch hatop with
hatop -s /var/run/haproxy.sock
haproxy should show some dummy services that are
configured by default.
To clean up, uninstall hatop and haproxy and remove
/etc/haproxy/haproxy.cfg
Best,
-ljuba
On 19.05, Stuart Henderson wrote:
> On 2018/05/18 23:24, Ljuba Nedeljkovic wrote:
> > Slightly improved port, using variables instead of
> > hard coded version numbers
>
> Here's a diff on top of yours, and please remove the patch:
>
> - COMMENT typo
> - no need to use V, the version is only referenced once
> - license say "GPLv3 or later" -> use GPLv3+
> - let MASTER_SITES work even if MASTER_SITE_GOOGLECODE expands
> to more than one URL (it's a user-changeable setting)
> - drop the MODPY_VERSION, this is the default anyway
> - replace patch + SUBST_CMD with MODPY_ADJ_FILES
>
> I don't use haproxy so can't test runtime.
>
>
>
> --- Makefile.orig Sat May 19 01:19:06 2018
> +++ Makefile Sat May 19 01:20:44 2018
> @@ -1,9 +1,8 @@
> # $OpenBSD$
>
> -COMMENT = interactive ncurses client for haroxy
> +COMMENT = interactive ncurses client for haproxy
>
> -V = 0.7.7
> -DISTNAME = hatop-${V}
> +DISTNAME = hatop-0.7.7
>
> CATEGORIES = net
>
> @@ -11,23 +10,19 @@ HOMEPAGE =
> http://feurix.org/projects/hatop/
>
> MAINTAINER = Ljuba Nedeljkovic <[email protected]>
>
> -# GPLv3
> +# GPLv3+
> PERMIT_PACKAGE_CDROM = Yes
>
> -MASTER_SITES = ${MASTER_SITE_GOOGLECODE}hatop/
> +MASTER_SITES = ${MASTER_SITE_GOOGLECODE:=hatop/}
>
> MODULES = lang/python
> -MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
>
> RUN_DEPENDS = net/haproxy
>
> NO_BUILD = Yes
> NO_TEST = Yes
>
> -SUBST_VARS += MODPY_VERSION
> -
> -pre-install:
> - ${SUBST_CMD} ${WRKSRC}/bin/hatop
> +MODPY_ADJ_FILES = bin/hatop
>
> do-install:
> ${INSTALL_SCRIPT} ${WRKSRC}/bin/hatop ${PREFIX}/bin/
>
hatop-0.7.7.tar.gz
Description: Binary data
