On 2018/05/20 16:48, Mikolaj Kucharski wrote:
> Hi,
>
> I wanted to fix plist in py-asn1crypto, but looked at home
> page and I've noticed new version available on GitHub
> releases page.
>
> make test for py2 and py3 pass and simple testing of ansible
> doesn't show any issues.
>
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/security/py-asn1crypto/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -u -r1.1.1.1 Makefile
> --- Makefile 5 Nov 2017 17:44:18 -0000 1.1.1.1
> +++ Makefile 20 May 2018 15:35:33 -0000
> @@ -2,10 +2,9 @@
>
> COMMENT = fast ASN.1 parser and serializer
>
> -MODPY_EGG_VERSION = 0.23.0
> -GH_TAGNAME = ${MODPY_EGG_VERSION}
> -GH_ACCOUNT = wbond
> -GH_PROJECT = asn1crypto
> +MODPY_EGG_VERSION = 0.24.0
> +DISTNAME = asn1crypto-${MODPY_EGG_VERSION}
> +DISTFILES = ${DISTNAME}{${MODPY_EGG_VERSION}}.tar.gz
> PKGNAME = py-${DISTNAME}
>
> CATEGORIES = security
> @@ -14,6 +13,8 @@ HOMEPAGE = https://github.com/wbond/asn1
>
> # MIT
> PERMIT_PACKAGE_CDROM = Yes
> +
> +MASTER_SITES = https://github.com/wbond/asn1crypto/archive/
If it's necessary to use the github version and there's only an
autogenerated file (rather than an uploaded release asset) then please
stick to GH_* variables rather than the DISTNAME+DISTFILES+MASTER_SITES
mess..
But it would be preferable to switch to the pypi tarball.
> -@comment
> lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
...
> -@comment
> lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/
Please kill the trailing /, update-plist no longer adds it.
