Been seeing a few of these lately:

        gimp: vfprintf %s NULL in "Bookmark '%s' cannot be removed"
        pidgin: vfprintf %s NULL in "Bookmark '%s' cannot be removed"

Patch below silences them. Not sure if the "Remove the bookmark" string
can be reached with name == NULL, but why not treat the two cases the
same way.

Index: Makefile
===================================================================
RCS file: /var/cvs/ports/x11/gtk+2/Makefile,v
retrieving revision 1.222
diff -u -p -r1.222 Makefile
--- Makefile    9 Jan 2018 13:22:24 -0000       1.222
+++ Makefile    22 Jun 2018 03:26:54 -0000
@@ -9,6 +9,7 @@ COMMENT-cups=           gtk+2 CUPS print backend
 
 GNOME_VERSION=         2.24.32
 GNOME_PROJECT=         gtk+
+REVISION=              0
 
 PKGNAME-main=          gtk+2-${GNOME_VERSION}
 PKGNAME-cups=          gtk+2-cups-${GNOME_VERSION}
Index: patches/patch-gtk_gtkfilechooserdefault_c
===================================================================
RCS file: patches/patch-gtk_gtkfilechooserdefault_c
diff -N patches/patch-gtk_gtkfilechooserdefault_c
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ patches/patch-gtk_gtkfilechooserdefault_c   22 Jun 2018 03:25:59 -0000
@@ -0,0 +1,17 @@
+$OpenBSD$
+
+Index: gtk/gtkfilechooserdefault.c
+--- gtk/gtkfilechooserdefault.c.orig
++++ gtk/gtkfilechooserdefault.c
+@@ -2822,9 +2822,9 @@ bookmarks_check_remove_sensitivity (GtkFileChooserDefa
+       gtk_widget_set_sensitive (impl->browse_shortcuts_remove_button, 
removable);
+ 
+       if (removable)
+-        tip = g_strdup_printf (_("Remove the bookmark '%s'"), name);
++        tip = g_strdup_printf (_("Remove the bookmark '%s'"), name ? name : 
"(null)");
+       else
+-        tip = g_strdup_printf (_("Bookmark '%s' cannot be removed"), name);
++        tip = g_strdup_printf (_("Bookmark '%s' cannot be removed"), name ? 
name : "(null)");
+ 
+       gtk_widget_set_tooltip_text (impl->browse_shortcuts_remove_button, tip);
+       g_free (tip);

Reply via email to