Hi --
On 08/19/18 12:32, [email protected] wrote:
Hey Jason,
thank you for the information.
Here is the tar.gz port file attached to this email.
:-)
Jason Valencia <[email protected]> hat am 19. August 2018 um 18:10 geschrieben:
[email protected] wrote:
What are the next steps, what should I do to bring it into the ports
tree?
The normal way it to make a gzipped tarball of the port and send it to
this list (ports@). To do that, go to the directory containing the port
and run some variation of:
$ tar -czf nng.tar.gz nng
And attach the resulting file in an email to this list.
I'll preface by saying that you should read (or re-read) the porter's
handbook in the FAQ, and perhaps the manual pages for ports (`apropos
ports' should get you started).
Your COMMENT is not a comment; "light-weight brokerless messaging" would
be a start. But maybe it's more correct to say it's a "light-weight
brokerless messaging library" or something? Maybe "suite"? I don't know,
I've never heard of this software but I feel like it needs some sort of
clarifying word at the end.
You use one of GH_* or MASTER_SITES, not both. See Makefile.template in
PORTSDIR/infrastructure/templates. Also, the MASTER_SITES points to a
different repo than GH_ACCOUNT, so pick one.
It seems like you're trying to use an intermediate version, which makes
sense to my reading since OpenBSD support was just added upstream. So
you should host your own tarball instead and version it accordingly.
Judging by the release structure of nng, it would be something like
1.0.1.20180819, at least that's how I usually do such things (though
it's not the only way you can do it). This will fix your distinfo as a
side effect, which is good because currently the distinfo entries are
unacceptable since they're not versioned.
There's no license marker. See Makefile.template, or any other port
Makefile.
You should rearrange all variables according to Makefile.template and
reel in extra tabs.
You have a SHARED_LIBS line but no shared libraries listed in pkg/PLIST.
You should use MODULES=devel/cmake only, see port-modules(5). You have
both a MODULES line and a BDEP line. If you're using the cmake MODULE,
it automagically uses Ninja, so you don't need a ninja BDEP line either.
If you have unzip listed in BDEPs because you're downloading a zip file,
don't do that. The ports infrastructure is smart enough to do that for
you. So basically, you don't need the BDEPs at all here.
You don't need SEPARATE_BUILD or CONFIGURE_ARGS, as the cmake MODULES
does this for you.
Your pkg/DESCR isn't a description. Please look at any other port, but
perhaps best to look at a port that does something similar to nng for a
model to follow.
You are using the old PLIST @comment $RCS ID$ line. Meaning you either
made this port on OpenBSD 6.3 (you should be using -current in that
case), you made this a very long time ago, or you did it by hand. There
are convenient `make plist' and `make update-plist' targets that do this
for you.
Start with that and resubmit. Then we can move on to building and
run-testing this.
~Brian
