On Mon, 20 Aug 2018 19:55:04 -0500, Edward Lopez-Acosta
<[email protected]> wrote:
> Hello all,
>
> Simple version update for www/py-requests to 2.19.1, contacted
> maintainer but did not hear back so submitting here. Copied the port
> to mystuff/ before making the changes, hopefully that does not affect
> too much.
>
> Failing tests are for the Pipfile which is not included in the
> package as its just for development. I would not mind extra eyes on
> this though.
Did you test anything that depends on this port? There are 68 ports
which have a rdep on requests so it's not 'just another ports'. Any
reason that would motivate the update?
I don't know if it's the way you created your patch, or thunderbird, or
both but your patch won't apply. You can attach it if you want to bypass
thunderbird messing with it. If you don't know how to use git, just use
cvs: a mere `cvs diff > diff.txt` and attaching the result is enough.
No need to diff file by file, from mystuff and the regular port.
Some comments inlined.
> --- /usr/ports/www/py-requests/Makefile Mon Aug 20 19:47:13 2018
> +++ /usr/ports/mystuff/www/py-requests/Makefile Mon Aug 20 19:46:43
> 2018 @@ -2,7 +2,7 @@
>
> COMMENT= elegant and simple HTTP library for Python
>
> -MODPY_EGG_VERSION= 2.18.4
> +MODPY_EGG_VERSION= 2.19.1
> DISTNAME= requests-${MODPY_EGG_VERSION}
> PKGNAME= py-${DISTNAME}
> REVISION= 0
revision line should be removed
> --- /usr/ports/www/py-requests/pkg/PLIST Thu Jul 26 19:02:41
> 2018 +++ /usr/ports/mystuff/www/py-requests/pkg/PLIST Mon Aug
> 20 19:48:26 2018
> @@ -8,7 +8,7 @@ lib/python${MODPY_VERSION}/site-packages/requests-${MO
>
> lib/python${MODPY_VERSION}/site-packages/requests-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
>
> lib/python${MODPY_VERSION}/site-packages/requests-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
> lib/python${MODPY_VERSION}/site-packages/requests/__init__.py
> -${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}/
> +lib/python${MODPY_VERSION}/site-packages/requests/${MODPY_PYCACHE}
That doesn't look good to me did both py2 and py3 version package
correctly?
Cheers,
Daniel
