Thanks Charlene! I'm so excited. I made a little checklist for myself based on feedback from you and Kurt: https://gist.github.com/ike/d213a1a413b7fbcc7a097ecfde06e86a
Have a great weekend! Ike -- Isaac Lewis ike.io - 541-705-5427 Sent from ProtonMail, Swiss-based encrypted email. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Saturday, March 30, 2019 4:21 PM, Charlene Wendling <[email protected]> wrote: > Hi, > > On Sat, 30 Mar 2019 02:10:09 +0000 > Isaac Lewis [email protected] wrote: > > > convmv (https://www.j3e.de/linux/convmv/) moves from 2.03 to 2.05. No > > dependency changes or api changes, as far as I can tell. > > This is my first patch! I had a lot of fun, and welcome all feedback. > > I don't even know if I packaged it up right. > > Thanks for the help, > > Ike > > Thanks! It's a good choice for a first update, this is a very > simple port :) > > Some comments: > > - Please send a diff instead of a tarball when it's an update. > It's done by issuing this in the port top directory: > > $ cvs diff > ~/myupdate.diff' > > > - If a HTTPS version of HOMEPAGE exists, we should use it > > Some other tweaks i made: > > - TEST_TARGET and MAKE_FLAGS are not needed anymore > as they're the default anyway > > - It's a simple Perl script and a manpage, so i added > PKG_ARCH=* > > Testing: > > - 'make test' passes, there is no consumer > > OK to commit it? > > Charlène. > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/converters/convmv/Makefile,v > retrieving revision 1.5 > diff -u -p -u -p -r1.5 Makefile > --- Makefile 10 Aug 2018 10:20:21 -0000 1.5 > +++ Makefile 30 Mar 2019 23:15:54 -0000 > @@ -1,15 +1,15 @@ > > > $OpenBSD: Makefile,v 1.5 2018/08/10 10:20:21 espie Exp $ > > ========================================================= > > COMMENT = convert filenames from one encoding to another > -DISTNAME = convmv-2.03 > +DISTNAME = convmv-2.05 > CATEGORIES = converters > -HOMEPAGE = http://www.j3e.de/linux/convmv/ > +HOMEPAGE = https://www.j3e.de/linux/convmv/ > > GPLv2+ > > ======= > > PERMIT_PACKAGE_CDROM = Yes > > MASTER_SITES = ${HOMEPAGE} > -TEST_TARGET = test > -MAKE_FLAGS = PREFIX='${PREFIX}' > + > +PKG_ARCH = * > > .include <bsd.port.mk> > > Index: distinfo > > ================ > > RCS file: /cvs/ports/converters/convmv/distinfo,v > retrieving revision 1.4 > diff -u -p -u -p -r1.4 distinfo > --- distinfo 4 Jul 2017 12:51:59 -0000 1.4 > +++ distinfo 30 Mar 2019 23:15:54 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (convmv-2.03.tar.gz) = +Jj9hQyO9avkj3U25LI85OEbYTOXSy/EHZGX3+zBwCc= > -SIZE (convmv-2.03.tar.gz) = 29688 > +SHA256 (convmv-2.05.tar.gz) = U7asiuT5vq7lvFYo9qU4K/0U9Cpb7T2IG4Kde1LYHKY= > +SIZE (convmv-2.05.tar.gz) = 30680
