On Mon 17/06/2019 19:50, Nam Nguyen wrote:
> This is a diff to update youtube-dl to 2019.06.08.
>
> Release notes:
> https://github.com/ytdl-org/youtube-dl/releases/tag/2019.06.08
>
> Tested on amd64 with youtube using mpv.
>
> The same number of tests fail. (I ran tests on two different computers
> so ignore the duration.)
>
> old version:
> Ran 2386 tests in 199.938s
>
> FAILED (errors=44)
>
> latest version:
> Ran 2380 tests in 120.676s
>
> FAILED (errors=44)
>
> The generated PLIST has four lines of the form:
> -lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/${MODPY_PYCACHE}/
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/${MODPY_PYCACHE}/
>
> I had to manually intervene in the generated PLIST and remove the
> leading ${MODPY_COMMENT} to keep it the same as the older PLIST. This
> seems safe, given targeting only python 3 and given port-modules(5):
>
> "The python module defines variables to allow a single PLIST to be used
> for both versions. Generate or update the PLIST using the python3
> FLAVOR, then edit it to prefix any lines creating MODPY_PYCACHE
> directories with MODPY_COMMENT."
I trust update-plist to do the right thing, and would keep the
${MODPY_COMMENT}-bits in. It doesn't seem to do any harm. That said,
removing these bits also doesn't do any harm.
Tested the port by grabbing content from a couple of websites other than
youtube. Works for me.
OK bket@
