On 2019/07/20 14:43, James Turner wrote: > On Sat, Jul 20, 2019 at 01:11:15AM +0200, Stefan Hagen wrote: > > Hello, > > > > This is my first contribution to OpenBSD. I've updated port mail/mu > > to version 1.2. > > > > The software changes from Version 1.0 to 1.2 can be found here: > > https://github.com/djcb/mu/releases/tag/1.2 > > (There was no Version 1.1) > > > > Port changes: > > - Switched to MASTER_SITES to grab the release file and not the > > auto-generated Github tarball (which may change checksum). > > - updated dependency gmime->gmime30 > > - new dependency glib-json > > - change emacs dependency to emacs,no_x11 (enough to build)
This should stay as it was - it is better for bulk builds if all ports that have a build dependency on emacs depend on the same flavour, and the "unflavoured" version is the most common. > > - adding myself as maintainer > > > > I added a patch to bring g_vasprintf into scope. > > > > I'm mainly using "mu" and not "mu4e". > > Tests for mu4e would be welcome. > > > > Compiling and tests done on a current snapshot/amd64. > > > > Did I do this right? > > Comments? Improvements? Ok? > > > > Best Regards, > > Stefan > > Looks pretty good to me, however since it's a brand new version you can > just remove the REVISION. REVISION is only needed if you make changes to > the current version of the port and make changes that require a bump. Right. Also (not new but might as well fix it) the canonical place for WANTLIB is right after PERMIT_*, and it could do with a tab after MASTER_SITES= to line things up. Otherwise OK with me.
