On Mon, Aug 19 2019, Jeremie Courreges-Anglas <[email protected]> wrote:
> On Mon, Aug 19 2019, Charlene Wendling <[email protected]> wrote:
>>> http://build-failures.rhaalovely.net/sparc64/2019-08-15/devel/woboq_codebrowser.log
>> (same thing for macppc, but latest full bulk report is archived)
>>
>> This software requires clang as it uses libclang to analyse the code,
>> but on base-gcc archs:
>>
>> ===>  Compiler link: gcc -> /usr/local/bin/clang
>> ===>  Compiler link: cc -> /usr/local/bin/clang
>> ===>  Compiler link: clang -> /usr/local/bin/clang
>> ===>  Compiler link: c++ -> /usr/bin/c++
>> [...] 
>> -- The C compiler identification is Clang 8.0.0
>> -- The CXX compiler identification is GNU 4.2.1
>>
>> It is lacking a COMPILER line to make it pick clang++. No REVISION 
>> bump is needed, as it has never been built on base-gcc archs
>> since its import.
>>
>> Once added it builds fine on macppc [0].
>>
>> OK?
>
> yep, but obvious comment is obvious...

Thinking more about it...

>> Charlène.
>>
>>
>> [0] https://bin.charlenew.xyz/woboq_codebrowser.log
>>
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/devel/woboq_codebrowser/Makefile,v
>> retrieving revision 1.1.1.1
>> diff -u -p -u -p -r1.1.1.1 Makefile
>> --- Makefile 22 Jun 2019 12:16:56 -0000      1.1.1.1
>> +++ Makefile 19 Aug 2019 18:25:27 -0000
>> @@ -26,6 +26,9 @@ PERMIT_PACKAGE =   Yes
>>  # uses pledge()
>>  WANTLIB =           ${COMPILER_LIBCXX} c m
>>  
>> +# required to use ports-clang as CXX on base-gcc arches
>> +COMPILER =          base-clang ports-clang
>> +
>>  MODULES =           devel/cmake \
>>                      lang/clang

COMPILER and MODULES = lang/clang look a bit redundant.  I'd suggest
using something more explicit:

COMPILER = base-clang ports-clang
BUILD_DEPENDS = devel/llvm
RUN_DEPENDS = devel/llvm

like done in devel/include-what-you-use.

>>  RUN_DEPENDS =               devel/llvm
>>
>>
>>
>>
>>
>>
>>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to