On 2019/11/07 22:46, Rafael Sadowski wrote:
> On Thu Nov 07, 2019 at 09:25:09PM +0000, Raf Czlonka wrote:
> > On Thu, Nov 07, 2019 at 08:58:50PM GMT, Rafael Sadowski wrote:
> > > At first glance it is not clear which version is used here.
> > >
> > > I guess this is much clearer to read and overview. Homepage says:
> > >
> > > " The id3lib library is open-source software, licensed under the GNU
> > > Library General Public License (LGPL)."
> > >
> > > so I change the license comment.
> > >
> > > Index: Makefile
> > > ===================================================================
> > > RCS file: /cvs/ports/audio/id3lib/Makefile,v
> > > retrieving revision 1.29
> > > diff -u -p -u -p -r1.29 Makefile
> > > --- Makefile 12 Jul 2019 20:43:34 -0000 1.29
> > > +++ Makefile 7 Nov 2019 20:40:27 -0000
> > > @@ -2,16 +2,16 @@
> > >
> > > COMMENT= library for manipulating ID3v1 and ID3v2 tags
> > >
> > > -VERSION= 3.8
> > > -DISTNAME= id3lib-${VERSION}.3
> > > +DISTNAME= id3lib-3.8.3
> > > REVISION = 9
> > > -CATEGORIES= audio
> > > +CATEGORIES= audio
> > > +
> > > SHARED_LIBS += id3 4.0 # .3.8
> > >
> > > HOMEPAGE= http://id3lib.sourceforge.net/
> > >
> > > -# GPL
> > > -PERMIT_PACKAGE= Yes
> > > +# LGPLv3
> > ^^
> >
> > Hi Rafael,
> >
> > According to its sf.net[0] page, it is under version 2 of said license.
> > As a rule of thumb, if someone refers to LGPL as "Library GPL", then it,
> > most likely, is *not* version 3 ;^)
>
> Hi Raf, thanks the hint.
>
> >
> > [0] https://sourceforge.net/projects/id3lib/
>
> On [0] you click on "GNU Library General Public License (LGPL)." which
> is a link to: http://www.gnu.org/copyleft/lesser.html and this is a
> redirect to https://www.gnu.org/licenses/lgpl-3.0.html (NOT 2)
>
> >
> > Cheers,
> >
> > Raf
> >
> > > +PERMIT_PACKAGE= Yes
> > >
> > > WANTLIB= c m ${COMPILER_LIBCXX} z
> > >
> > >
> >
>
Check the source code files, it is LGPLv2+.
As you're tidying anyway can you make it so it doesn't use a mixture
of mostly "VAR=" and "VAR =" whitespace please.
I agree with moving the version to DISTNAME, VERSION isn't reused
so no need for the separate variable.
