On 2020/03/02 21:21, Laurence Tratt wrote:
> This is a new port for snare, a GitHub webhooks runner daemon. From
> pkg/DESCR:
> 
>   snare is a GitHub webhooks runner daemon. When snare receives a webhook
>   event from a given repository, it authenticates the request, and then
>   executes a user-defined "per-repo program" with information about the
>   webhook event.
> 
> More info at https://tratt.net/laurie/src/snare/
> 
> This version of the port is for snare 0.2.0; edd@ OK'd the 0.1.0 version of
> this port.

- "MODCARGO_CRATES_UPDATE += libc" isn't doing anything because the version
of libc in the MODCARGO_CRATES list is the same as the version in Cargo.lock
so please remove that

- if semarie's cargo diff goes in before this is committed, the openssl-sys
patch should be removed

- as a daemon it would be better if this had an rc script and dedicated uid
to run it as. probably also @sample the config file into ${SYSCONFDIR}?

- I'd prefer if the wasi MODCARGO_CRATES line was left how it came from
modcargo-gen-crates-licenses rather than splitting the license onto the
line before, i.e.

-# Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT
-MODCARGO_CRATES +=     wasi    0.9.0+wasi-snapshot-preview1
+MODCARGO_CRATES +=     wasi    0.9.0+wasi-snapshot-preview1    # Apache-2.0 
WITH LLVM-exception OR Apache-2.0 OR MIT

Reply via email to