On Tue May 12, 2020 at 12:27:20PM +0200, Klemens Nanni wrote:
> On Tue, May 12, 2020 at 07:09:42AM +0200, Rafael Sadowski wrote:
> > I am working on a new cmake-python symbiosis. Python2 was detected in my
> > last bulk. Looks like there is a typo in both Makefiles.
> These are no typos but valid make(1) syntax:  it states that the
> following command may fail.

.. and again learned something new.

> 
> Did you run into issues with this?

Yes and no. I saw the following lines in devel/llvm and thought I had
caused it with my cmake changes. But this happens even without my
changes, although we set MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}.

-- Could NOT find Python module pygments
-- Could NOT find Python module pygments.lexers.c_cpp
-- Found PythonInterp: /usr/local/bin/python2.7 (found version "2.7.18") 
-- Found PythonLibs: /usr/local/lib/libpython2.7.so.0.0 (found version
"2.7.18")

> 
> Alternatively, we could do
> 
>       ln -sf source target
> 
> that is, no leading dash but forcing the target.  If that fails, make
> should fail because there is a problem.
> 
> > diff --git a/devel/clang-tools-extra/Makefile 
> > b/devel/clang-tools-extra/Makefile
> > index dfebc54269f..664da0e7735 100644
> > --- a/devel/clang-tools-extra/Makefile
> > +++ b/devel/clang-tools-extra/Makefile
> > @@ -15,7 +15,7 @@ COMMENT=  Clang extra tools
> >  LLVM_V =   8.0.1
> >  DISTNAME = llvm-${LLVM_V}.src
> >  PKGNAME=   clang-tools-extra-${LLVM_V}
> > -REVISION=  3
> > +REVISION=  4
> >  
> >  CATEGORIES =       devel
> >  
> > @@ -83,7 +83,7 @@ post-extract:
> >  
> >  pre-configure:
> >     @${SUBST_CMD} ${WRKSRC}/tools/clang/lib/Driver/ToolChains/OpenBSD.cpp
> > -   -@ln -s ${MODPY_BIN} ${WRKDIR}/bin/python
> > +   @ln -s ${MODPY_BIN} ${WRKDIR}/bin/python
> 
This workaround should no longer exist for cmake ports. *WIP*
Preview:
https://github.com/sizeofvoid/wip-ports/commit/a1b2879b832e52f64788c89bed62d0ea17c0f8c8

Rafael

Reply via email to