Landry Breuil <[email protected]> writes: > another way that implies less patching, as you already patch > CMakeLists.txt for cotire: > > @@ -85,7 +80,7 @@ include(TestCXXAcceptsFlag) > include(GNUInstallDirs) > > set(LIB_DESTINATION > - "${CMAKE_INSTALL_FULL_LIBDIR}" CACHE STRING "Define lib output directory > name" > + "lib" CACHE STRING "Define lib output directory name" > ) > > if(ENABLE_CYCLIC_CHECK) > > with that chunk added to patch-CMakeLists.txt, no need to patch the .cmake > files to fiddle with prefix/LIB_DESTINATION, and the resulting .pc look > correct.
I really like this. Update tarball with this applied. > On Fri, Jun 26, 2020 at 06:30:28PM +0200, Landry Breuil wrote: >> On Fri, Jun 26, 2020 at 11:02:42AM +0200, Omar Polo wrote: >> > >> > Landry Breuil <[email protected]> writes: > > <snip> >> > unfortunately, after a while it core dumps: >> > >> > ... >> > [----------] 102 tests from IndexWriterTest >> > [ RUN ] IndexWriterTest.testDocCount >> > [ OK ] IndexWriterTest.testDocCount (7 ms) >> > [ RUN ] IndexWriterTest.testAddIndexOnDiskFull >> > Segmentation fault (core dumped) >> >> Tests are still running here, dunno if they will fail, but it's always good >> to >> have them at least available/running. > > Only one failed here, and it was properly handled by the framework: > > [----------] Global test environment tear-down > [==========] 1472 tests from 201 test cases ran. (1152166 ms total) > [ PASSED ] 1471 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] DateToolsTest.testParseDateLocale > > 1 FAILED TEST > terminating with uncaught exception of type std::bad_cast: std::bad_cast > Abort trap (core dumped) > > so that looks pretty good testing-wise. > > Landry I've re-runned the test and I've got the same result as you. For the record, the failing test tries to parse some dates in different locales (en_GB and en_US.UTF-8): ... 97 DateTools::setDateOrder(DateTools::DATEORDER_LOCALE); 98 EXPECT_EQ(DateTools::parseDate(L"01122005", std::locale("en_GB.UTF-8")), ptime(date(2005, 12, 01))); 99 EXPECT_EQ(DateTools::parseDate(L"011205", std::locale("en_GB.UTF-8")), ptime(date(2005, 12, 01))); 100 EXPECT_EQ(DateTools::parseDate(L"01/12/2005", std::locale("en_GB.UTF-8")), ptime(date(2005, 12, 01))); 101 EXPECT_EQ(DateTools::parseDate(L"01/12/05", std::locale("en_GB.UTF-8")), ptime(date(2005, 12, 01))); 102 EXPECT_EQ(DateTools::parseDate(L"1/12/2005", std::locale("en_GB.UTF-8")), ptime(date(2005, 12, 01))); ... I don't have enough knowledge/time at the moment to fix this tbh.
luceneplusplus.tar.gz
Description: Binary data
