On Sat Jul 18, 2020 at 05:46:42PM +0100, Stuart Henderson wrote:
> Another port that fails because amd64 still includes libstdc++.
>
> It would be nice if porters running amd64 could remove /usr/lib/libstdc++.*
> so they find these problems before commit :)
>
>
> /usr/bin/libtool --tag=CC --mode=link cc -fvisibility=hidden -O2 -pipe -g
> -Wall -L/usr/local/lib -lintl -g -o aqbanking-cli main.o addsepadebitnote.o
> addtransaction.o chkiban.o fillgaps.o import.o export.o listaccs.o listbal.o
> listprofiles.o listtrans.o request.o util.o versions.o sepatransfer.o
> sepadebitnote.o sepamultijobs.o separecurtransfer.o updateconf.o control.o
> /pobj/aqbanking-6.2.1/aqbanking-6.2.1/src/libs/libaqbanking.la
> -L/usr/local/lib -lgwenhywfar -lstdc++
> Link error: stdc++ not found!
> at /usr/libdata/perl5/LT/Library.pm line 137.
> LT::Library::resolve_library(LT::Library=HASH(0x6d53f970),
> ARRAY(0x6c2a7570), 1, undef, "LT::Program") called at
> /usr/libdata/perl5/LT/Mode/Link/Program.pm line 84
> LT::Linker::Program::link(LT::Linker::Program=HASH(0x6d53fa40),
> LT::Program=HASH(0x6fb6d9e0), ARRAY(0x6132a880),
> LT::OSConfig=HASH(0x6132a7c0), ARRAY(0x6c2a7570),
> LT::Library::Stash=HASH(0x6c2a7560), ARRAY(0x6c2a7b90), ARRAY(0x5527d6c0),
> ...) called at /usr/libdata/perl5/LT/Mode/Link/Program.pm line 28
> LT::Program::link(LT::Program=HASH(0x6fb6d9e0), ARRAY(0x6132a880),
> LT::OSConfig=HASH(0x6132a7c0), ARRAY(0x6c2a7570),
> LT::Library::Stash=HASH(0x6c2a7560), ARRAY(0x6c2a7b90), ARRAY(0x5527d6c0),
> LT::Parser=HASH(0x65374c80), ...) called at
> /usr/libdata/perl5/LT/Mode/Link.pm line 235
> LT::Mode::Link::run(LT::Mode::Link=HASH(0x5527d040), ARRAY(0x6132a880),
> LT::Options=HASH(0x6132a870), LT::OSConfig=HASH(0x6132a7c0)) called at
> /usr/bin/libtool line 416
> warning: could not find a stdc++ library
> gmake[4]: *** [Makefile:594: aqbanking-cli] Error 2
> gmake[4]: Leaving directory
> '/pobj/aqbanking-6.2.1/aqbanking-6.2.1/src/tools/aqbanking-cli'
> gmake[3]: *** [Makefile:469: all-recursive] Error 1
> gmake[3]: Leaving directory '/pobj/aqbanking-6.2.1/aqbanking-6.2.1/src/tools'
> gmake[2]: *** [Makefile:469: all-recursive] Error 1
> gmake[2]: Leaving directory '/pobj/aqbanking-6.2.1/aqbanking-6.2.1/src'
> gmake[1]: *** [Makefile:757: all-recursive] Error 1
> gmake[1]: Leaving directory '/pobj/aqbanking-6.2.1/aqbanking-6.2.1'
> gmake: *** [Makefile:554: all] Error 2
> *** Error 2 in productivity/aqbanking
> (/usr/ports/infrastructure/mk/bsd.port.mk:2925
> '/pobj/aqbanking-6.2.1/.build_done': @cd /pobj/aqbankin...)
> *** Error 2 in productivity/aqbanking
> (/usr/ports/infrastructure/mk/bsd.port.mk:2584 'build':
> @lock=aqbanking-6.2.1; export _LOCKS_HELD=" a...)
> ===> Exiting productivity/aqbanking with an error
> *** Error 1 in /usr/ports (infrastructure/mk/bsd.port.subdir.mk:137 'build':
> @: ${echo_msg:=echo}; : ${target:=build}; for i in ; do eval...)
>
Noticed.
Index: Makefile
===================================================================
RCS file: /cvs/ports/productivity/aqbanking/Makefile,v
retrieving revision 1.23
diff -u -p -u -p -r1.23 Makefile
--- Makefile 16 Jul 2020 05:01:19 -0000 1.23
+++ Makefile 19 Jul 2020 15:09:43 -0000
@@ -3,6 +3,7 @@
COMMENT= online banking interface and financial data framework
DISTNAME= aqbanking-6.2.1
+REVISION= 0
SHARED_LIBS += aqbanking 3.0 # 39.2
@@ -13,10 +14,9 @@ HOMEPAGE= https://www.aquamaniac.de
# GPLv2 or GPLv3
PERMIT_PACKAGE = Yes
-WANTLIB += ${COMPILER_LIBCXX} c ffi gcrypt gmp gnutls gpg-error
-WANTLIB += gwenhywfar hogweed iconv idn2 intl ltdl lzma m nettle
-WANTLIB += p11-kit tasn1 unistring xml2 xmlsec1 xslt z
-
+WANTLIB += c ffi gcrypt gmp gnutls gpg-error gwenhywfar hogweed
+WANTLIB += iconv idn2 intl ltdl lzma m nettle p11-kit pthread
+WANTLIB += tasn1 unistring xml2 xmlsec1 xslt z
MASTER_SITES= https://www.aquamaniac.de/rdm/attachments/download/328/
Index: patches/patch-src_tools_aqbanking-cli_Makefile_in
===================================================================
RCS file: patches/patch-src_tools_aqbanking-cli_Makefile_in
diff -N patches/patch-src_tools_aqbanking-cli_Makefile_in
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_tools_aqbanking-cli_Makefile_in 19 Jul 2020 15:09:43
-0000
@@ -0,0 +1,16 @@
+$OpenBSD$
+
+Do not hardcode -lstdc++
+
+Index: src/tools/aqbanking-cli/Makefile.in
+--- src/tools/aqbanking-cli/Makefile.in.orig
++++ src/tools/aqbanking-cli/Makefile.in
+@@ -461,7 +461,7 @@ AM_CPPFLAGS = -I$(top_srcdir)/src/libs -I$(top_builddi
+ AM_CFLAGS = @visibility_cflags@
+ aqbanking_cli_LDADD = \
+ $(aqbanking_internal_libs) \
+- $(gwenhywfar_libs) -lstdc++
++ $(gwenhywfar_libs)
+
+ aqbanking_cli_SOURCES = \
+ main.c \